[vlc-commits] nsis: don' t skip the components page until we were able to save user choices

Ludovic Fauvet git at videolan.org
Sat Sep 28 01:46:25 CEST 2013


vlc | branch: master | Ludovic Fauvet <etix at videolan.org> | Sat Sep 28 00:52:53 2013 +0200| [ac8330105892f9ec93a9c5464736037da832c11d] | committer: Ludovic Fauvet

nsis: don't skip the components page until we were able to save user choices

This change will make the transition easier between the previously released
installer (that doesn't remember user choices) and this one. Without it the
old installer would fall back to the "Recommended" preset.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ac8330105892f9ec93a9c5464736037da832c11d
---

 extras/package/win32/NSIS/vlc.win32.nsi.in |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/extras/package/win32/NSIS/vlc.win32.nsi.in b/extras/package/win32/NSIS/vlc.win32.nsi.in
index df82620..156f356 100644
--- a/extras/package/win32/NSIS/vlc.win32.nsi.in
+++ b/extras/package/win32/NSIS/vlc.win32.nsi.in
@@ -749,9 +749,17 @@ Function PageFastUpdatePre
 FunctionEnd
 
 Function PageComponentsPre
+  ClearErrors
+  ReadRegStr $0 ${MEMENTO_REGISTRY_ROOT} `${MEMENTO_REGISTRY_KEY}` MementoSectionUsed
+  ; Backward compatibility:
+  ; Don't skip the components page until Memento was able to save the user choices.
+  IfErrors done
+
   ${If} $ReinstallType == 1
     Abort
   ${EndIf}
+
+done:
 FunctionEnd
 
 Function PageDirectoryPre



More information about the vlc-commits mailing list