[vlc-commits] macosx: ExtensionProvider: Add more log messages

[Marvin Scholz]

vlc | branch: master | Marvin Scholz <epirat07 at gmail.com> | Thu Dec  6 15:58:09 2018 +0100| [52b97ed0e1fa9b82019dcc635e45d5edcbf8ab3b] | committer: Marvin Scholz

macosx: ExtensionProvider: Add more log messages

Some error cases were not logged at all making it hard to figure out
whats going on when things do not behave as expected.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=52b97ed0e1fa9b82019dcc635e45d5edcbf8ab3b
---

 modules/gui/macosx/VLCExtensionsDialogProvider.m | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/modules/gui/macosx/VLCExtensionsDialogProvider.m b/modules/gui/macosx/VLCExtensionsDialogProvider.m
index 8c685d8c17..533d64ae0b 100644
--- a/modules/gui/macosx/VLCExtensionsDialogProvider.m
+++ b/modules/gui/macosx/VLCExtensionsDialogProvider.m
@@ -144,6 +144,7 @@ static NSView *createControlFromWidget(extension_widget_t *widget, id self)
                 return spinner;
             }
             default:
+                msg_Err(getIntf(), "Unhandled Widget type %i", widget->type);
                 return nil;
         }
     }
@@ -391,6 +392,8 @@ static void extensionDialogCallback(extension_dialog_t *p_ext_dialog,
 
         if (!control && !shouldDestroy) {
             control = createControlFromWidget(widget, self);
+            if (control == NULL)
+                msg_Err(getIntf(), "Failed to create control from widget!");
             updateControlFromWidget(control, widget, self);
             /* Ownership needs to be given-up, if ARC would remain with the
              * ownership, the object could be freed while it is still referenced