[vlc-commits] macosx: ExtensionProvider: Add more log messages

[Marvin Scholz]

vlc/vlc-3.0 | branch: master | Marvin Scholz <epirat07 at gmail.com> | Thu Dec  6 15:58:09 2018 +0100| [6cacbced3959849586148851eb444af70bf3f5f3] | committer: Jean-Baptiste Kempf

macosx: ExtensionProvider: Add more log messages

Some error cases were not logged at all making it hard to figure out
whats going on when things do not behave as expected.

(cherry picked from commit 52b97ed0e1fa9b82019dcc635e45d5edcbf8ab3b)
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=6cacbced3959849586148851eb444af70bf3f5f3
---

 modules/gui/macosx/VLCExtensionsDialogProvider.m | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/modules/gui/macosx/VLCExtensionsDialogProvider.m b/modules/gui/macosx/VLCExtensionsDialogProvider.m
index f721b708ff..f9c66f51be 100644
--- a/modules/gui/macosx/VLCExtensionsDialogProvider.m
+++ b/modules/gui/macosx/VLCExtensionsDialogProvider.m
@@ -140,6 +140,7 @@ static NSView *createControlFromWidget(extension_widget_t *widget, id self)
                 return spinner;
             }
             default:
+                msg_Err(getIntf(), "Unhandled Widget type %i", widget->type);
                 return nil;
         }
     }
@@ -384,6 +385,8 @@ static void extensionDialogCallback(extension_dialog_t *p_ext_dialog,
 
         if (!control && !shouldDestroy) {
             control = createControlFromWidget(widget, self);
+            if (control == NULL)
+                msg_Err(getIntf(), "Failed to create control from widget!");
             updateControlFromWidget(control, widget, self);
             /* Ownership needs to be given-up, if ARC would remain with the
              * ownership, the object could be freed while it is still referenced