[vlc-commits] dmo: do not release the block twice

Steve Lhomme git at videolan.org
Thu May 23 17:20:39 CEST 2019


vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Tue Jan 29 13:59:13 2019 +0100| [966879c5e23aef2779b64c573c291ad50e981f5c] | committer: Hugo Beauzée-Luyssen

dmo: do not release the block twice

We own the block though CMediaBufferCreate(), it will be released when the
CMediaBuffer is released by the DMO.

Introduced in a8b249bc6bf9cfd693389bf2c5c3c403955e241c

https://hackerone.com/reports/484387

Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=966879c5e23aef2779b64c573c291ad50e981f5c
---

 modules/codec/dmo/dmo.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/codec/dmo/dmo.c b/modules/codec/dmo/dmo.c
index 38fb03ce9c..c63090cff2 100644
--- a/modules/codec/dmo/dmo.c
+++ b/modules/codec/dmo/dmo.c
@@ -870,7 +870,6 @@ static int DecBlock( decoder_t *p_dec, block_t **pp_block )
 #ifdef DMO_DEBUG
             msg_Dbg( p_dec, "ProcessInput(): successful" );
 #endif
-            block_Release( p_block );
             *pp_block = NULL;
         }
     }



More information about the vlc-commits mailing list