[vlc-commits] dmo: do not release the block twice

Steve Lhomme git at videolan.org
Thu May 23 17:40:10 CEST 2019


vlc/vlc-3.0 | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Tue Jan 29 13:59:13 2019 +0100| [b17763ee2ab54222432f194ec0d5fbca5afaa34e] | committer: Hugo Beauzée-Luyssen

dmo: do not release the block twice

We own the block though CMediaBufferCreate(), it will be released when the
CMediaBuffer is released by the DMO.

Introduced in a8b249bc6bf9cfd693389bf2c5c3c403955e241c

https://hackerone.com/reports/484387

Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>
(cherry picked from commit 966879c5e23aef2779b64c573c291ad50e981f5c)
Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=b17763ee2ab54222432f194ec0d5fbca5afaa34e
---

 modules/codec/dmo/dmo.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/codec/dmo/dmo.c b/modules/codec/dmo/dmo.c
index ba59c613ba..e4d9e90052 100644
--- a/modules/codec/dmo/dmo.c
+++ b/modules/codec/dmo/dmo.c
@@ -893,7 +893,6 @@ static int DecBlock( decoder_t *p_dec, block_t **pp_block )
 #ifdef DMO_DEBUG
             msg_Dbg( p_dec, "ProcessInput(): successful" );
 #endif
-            block_Release( p_block );
             *pp_block = NULL;
         }
     }



More information about the vlc-commits mailing list