[vlc-commits] update: Fix potential null pointer dereference

Hugo Beauzée-Luyssen git at videolan.org
Thu May 23 17:20:51 CEST 2019


vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Mon Feb 11 15:22:38 2019 +0100| [fd3acfe9eb94b9edcf28fc83d519810ebeb859db] | committer: Hugo Beauzée-Luyssen

update: Fix potential null pointer dereference

https://hackerone.com/reports/484787

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fd3acfe9eb94b9edcf28fc83d519810ebeb859db
---

 src/misc/update_crypto.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/misc/update_crypto.c b/src/misc/update_crypto.c
index 4d36b304c7..d3d555fc60 100644
--- a/src/misc/update_crypto.c
+++ b/src/misc/update_crypto.c
@@ -857,6 +857,9 @@ uint8_t *hash_from_public_key( public_key_t *p_pkey )
         p_pkey->sig.type > POSITIVE_KEY_SIGNATURE )
         return NULL;
 
+    if( p_pkey->psz_username == NULL )
+        return NULL;
+
     gcry_error_t error = 0;
     gcry_md_hd_t hd;
 



More information about the vlc-commits mailing list