[vlc-commits] update: Fix potential null pointer dereference

[Hugo Beauzée-Luyssen]

vlc/vlc-3.0 | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Mon Feb 11 15:22:38 2019 +0100| [ce7cb059e8d61e4fcd47c079cb951f59b4808f98] | committer: Hugo Beauzée-Luyssen

update: Fix potential null pointer dereference

https://hackerone.com/reports/484787

(cherry picked from commit fd3acfe9eb94b9edcf28fc83d519810ebeb859db)
Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=ce7cb059e8d61e4fcd47c079cb951f59b4808f98
---

 src/misc/update_crypto.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/misc/update_crypto.c b/src/misc/update_crypto.c
index 1ed64769a0..87800d11a4 100644
--- a/src/misc/update_crypto.c
+++ b/src/misc/update_crypto.c
@@ -858,6 +858,9 @@ uint8_t *hash_from_public_key( public_key_t *p_pkey )
         p_pkey->sig.type > POSITIVE_KEY_SIGNATURE )
         return NULL;
 
+    if( p_pkey->psz_username == NULL )
+        return NULL;
+
     gcry_error_t error = 0;
     gcry_md_hd_t hd;