[vlc-commits] qml: disable highlight auto scroll in toolbar editor

[Fatih Uzunoglu]

vlc | branch: master | Fatih Uzunoglu <fuzun54 at outlook.com> | Fri Apr  2 01:22:41 2021 +0300| [670a5dea2604a475d729aef03c6ddb5f0b39daf7] | committer: Pierre Lamot

qml: disable highlight auto scroll in toolbar editor

This patch intends to fix #25576 /
https://code.videolan.org/videolan/vlc/-/issues/25576

Signed-off-by: Pierre Lamot <pierre at videolabs.io>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=670a5dea2604a475d729aef03c6ddb5f0b39daf7
---

 modules/gui/qt/dialogs/toolbar/qml/EditorDNDView.qml       |  2 ++
 .../gui/qt/dialogs/toolbar/qml/ToolbarEditorButtonList.qml | 14 ++++++++++----
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/modules/gui/qt/dialogs/toolbar/qml/EditorDNDView.qml b/modules/gui/qt/dialogs/toolbar/qml/EditorDNDView.qml
index 5e659e79f5..d27e91fbc7 100644
--- a/modules/gui/qt/dialogs/toolbar/qml/EditorDNDView.qml
+++ b/modules/gui/qt/dialogs/toolbar/qml/EditorDNDView.qml
@@ -29,6 +29,8 @@ ListView {
     orientation: Qt.Horizontal
     clip: true
 
+    highlightFollowsCurrentItem: false
+
     property bool containsDrag: footerItem.dropVisible
 
     property alias scrollBar: scrollBar
diff --git a/modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorButtonList.qml b/modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorButtonList.qml
index f90c88780d..239c9b16f8 100644
--- a/modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorButtonList.qml
+++ b/modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorButtonList.qml
@@ -29,13 +29,10 @@ GridView{
     id: allButtonsView
     clip: true
 
-    highlight: Rectangle{
-        color: VLCStyle.colors.bgHover
-    }
     ScrollBar.vertical: ScrollBar { policy: ScrollBar.AlwaysOn }
     model: controlButtons.buttonL.length
 
-    highlightMoveDuration: 0 //ms
+    highlightFollowsCurrentItem: false
 
     cellWidth: VLCStyle.cover_small
     cellHeight: cellWidth
@@ -139,6 +136,15 @@ GridView{
 
         onEntered: allButtonsView.currentIndex = index
 
+        Loader {
+            active: allButtonsView.currentIndex === index
+            anchors.fill: parent
+
+            sourceComponent: Rectangle {
+                color: VLCStyle.colors.bgHover
+            }
+        }
+
         ColumnLayout{
             id: listelemlayout
             anchors.fill: parent