[vlc-commits] macosx: Move out sidebar handling in own data source object

David Fuhrmann git at videolan.org
Tue Apr 6 09:55:41 UTC 2021


vlc/vlc-3.0 | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Fri Apr  2 11:50:11 2021 +0200| [abbc95861f12992a773e67867851801fb1ea9858] | committer: David Fuhrmann

macosx: Move out sidebar handling in own data source object

Move delegate and datasource handling of sidebar into own
object. This decouples and cleans up the VLCMainWindow class.

Additionally, delegate and dataSource object cannot inherit
from an NSWindow class, as it is not allowed to contruct weak
references for such objects on old OS versions (Mac OS 10.7).

close vlc#25403

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=abbc95861f12992a773e67867851801fb1ea9858
---

 .../package/macosx/vlc.xcodeproj/project.pbxproj   |   6 +
 modules/gui/macosx/Makefile.am                     |   1 +
 modules/gui/macosx/VLCAddonsWindowController.m     |   4 +-
 modules/gui/macosx/VLCMainWindow.h                 |   7 +-
 modules/gui/macosx/VLCMainWindow.m                 | 323 +-----------------
 modules/gui/macosx/VLCSidebarDataSource.h          |  42 +++
 modules/gui/macosx/VLCSidebarDataSource.m          | 359 +++++++++++++++++++++
 7 files changed, 427 insertions(+), 315 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commitdiff;h=abbc95861f12992a773e67867851801fb1ea9858


More information about the vlc-commits mailing list