[vlc-commits] [Git][videolan/vlc][3.0.x] qt: fix signal loop when toggling record

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
b56c6896 by Pierre Lamot at 2026-09-16T14:32:40+00:00
qt: fix signal loop when toggling record

The toggle signal was emited when recording state change externally, which would
change the record state again, creating a loop

Listening to the clicked event is enough here, as it's emitted when the user
actively clicks the button and not when the toggle state is changed
programmatically

fix: #30143

- - - - -


1 changed file:

- modules/gui/qt/components/controller.cpp


Changes:

=====================================
modules/gui/qt/components/controller.cpp
=====================================
@@ -333,7 +333,7 @@ QWidget *AbstractController::createWidget( buttonType_e button, int options )
         QToolButton *recordButton = new QToolButton;
         setupButton( recordButton );
         recordButton->setCheckable( true );
-        connect( recordButton, &QToolButton::toggled, toolbarActionsMapper, QOverload<>::of(&QSignalMapper::map) );
+        connect( recordButton, &QToolButton::clicked, toolbarActionsMapper, QOverload<>::of(&QSignalMapper::map) );
         toolbarActionsMapper->setMapping( recordButton, RECORD_ACTION );
         connect( THEMIM->getIM(), &InputManager::recordingStateChanged, recordButton, &QToolButton::setChecked );
         BUTTON_SET_BAR(  recordButton );



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/b56c68965868ee48bed5ce1317f37cc648231c20

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/b56c68965868ee48bed5ce1317f37cc648231c20
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help