[vlc-commits] [Git][videolan/vlc][3.0.x] 2 commits: macosx: codesign: skip frameworks that are not bundled

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch 3.0.x at VideoLAN / VLC


Commits:
4a9f5c4d by Felix Paul Kühne at 2026-09-16T15:09:24+00:00
macosx: codesign: skip frameworks that are not bundled

- - - - -
a0de74f8 by Felix Paul Kühne at 2026-09-16T15:09:24+00:00
macosx: adhoc sign binaries

This fixes launch of arm64 builds. Opening the application bundle will
still raise a verification failure but it will no longer be rejected as
corrupted.

Depending on the deployed macOS version right-click and choose Open to
launch or use System Settings -> Privacy & Security -> Open Anyway.

Fixes #27739

- - - - -


2 changed files:

- extras/package/macosx/codesign.sh
- extras/package/macosx/package.mak


Changes:

=====================================
extras/package/macosx/codesign.sh
=====================================
@@ -110,11 +110,15 @@ find VLC.app/Contents/Frameworks -type f -name "*.txt" -exec rm '{}' \;
 
 info "Signing frameworks"
 
-sign "VLC.app/Contents/Frameworks/Growl.framework/Versions/A" "com.growl.growlframework"
+if [ -e "VLC.app/Contents/Frameworks/Growl.framework" ]; then
+    sign "VLC.app/Contents/Frameworks/Growl.framework/Versions/A" "com.growl.growlframework"
+fi
 
-sign "VLC.app/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupdate.app/Contents/MacOS/fileop"
-sign "VLC.app/Contents/Frameworks/Sparkle.framework/Resources/Autoupdate.app"
-sign "VLC.app/Contents/Frameworks/Sparkle.framework/Versions/A"
+if [ -e "VLC.app/Contents/Frameworks/Sparkle.framework" ]; then
+    sign "VLC.app/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupdate.app/Contents/MacOS/fileop"
+    sign "VLC.app/Contents/Frameworks/Sparkle.framework/Resources/Autoupdate.app"
+    sign "VLC.app/Contents/Frameworks/Sparkle.framework/Versions/A"
+fi
 
 if [ -e "VLC.app/Contents/Frameworks/Breakpad.framework" ]; then
     sign "VLC.app/Contents/Frameworks/Breakpad.framework/Resources/breakpadUtilities.dylib"
@@ -192,11 +196,16 @@ if [ -e "VLC.app/Contents/Frameworks/Breakpad.framework" ]; then
     codesign --verify -vv VLC.app/Contents/Frameworks/Breakpad.framework
 fi
 
-codesign --verify -vv VLC.app/Contents/Frameworks/Growl.framework
-codesign --verify -vv VLC.app/Contents/Frameworks/Sparkle.framework
+if [ -e "VLC.app/Contents/Frameworks/Growl.framework" ]; then
+    codesign --verify -vv VLC.app/Contents/Frameworks/Growl.framework
+fi
 
-info "Validating autoupdate app"
-codesign --verify -vv VLC.app/Contents/Frameworks/Sparkle.framework/Versions/Current/Resources/Autoupdate.app
+if [ -e "VLC.app/Contents/Frameworks/Sparkle.framework" ]; then
+    codesign --verify -vv VLC.app/Contents/Frameworks/Sparkle.framework
+
+    info "Validating autoupdate app"
+    codesign --verify -vv VLC.app/Contents/Frameworks/Sparkle.framework/Versions/Current/Resources/Autoupdate.app
+fi
 
 info "Validating complete bundle"
 codesign --verify --deep --strict --verbose=4 VLC.app


=====================================
extras/package/macosx/package.mak
=====================================
@@ -69,7 +69,8 @@ endif
 	fi
 	find $@ -type d -exec chmod ugo+rx '{}' \;
 	find $@ -type f -exec chmod ugo+r '{}' \;
-
+	## Ad-hoc sign the bundle
+	$(srcdir)/extras/package/macosx/codesign.sh -i -
 
 package-macosx: VLC.app
 	rm -f "$(top_builddir)/vlc-$(VERSION).dmg"



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/b56c68965868ee48bed5ce1317f37cc648231c20...a0de74f8d1d0b9bc1cece64d5eaf4099467d1d1a

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/b56c68965868ee48bed5ce1317f37cc648231c20...a0de74f8d1d0b9bc1cece64d5eaf4099467d1d1a
You're receiving this email because of your account on code.videolan.org. Manage all notifications: https://code.videolan.org/-/profile/notifications | Help: https://code.videolan.org/help