[rfc] Getting rid of intf_WarnMsg

Gildas Bazin gbazin at netcourrier.com
Sat May 4 11:23:52 CEST 2002


On Friday 03 May 2002 02:10, Samuel Hocevar wrote:
>    Hi! Here is my latest idea in my continuous attempt at breaking
> everything in vlc: getting rid of the levels in intf_WarnMsg. Frankly,
> who is the vout developer to judge that the number of direct buffers
> is more important than the amount of garbage bytes collected by the
> input layer?
> 
>    These pieces of information are completely unrelated, so what I am
> suggesting is instead of filtering messages by warning level, filter
> them by module or by thread type (vout, aout, etc.), which can be done
> automatically by a macro without adding much complexity to the code.
> So we'd end with roughly 3 functions (msg_Info, msg_Warn, msg_Err) and
> then give the ability to the user to choose what to display and what to
> filter out, with flags such as "--warning aout" or "-w input".
> 
>    Is there any fantastic feature of the warning messages level that I
> may be missing and which might be worth keeping? Originally Christophe
> intended the warning level to range from 1 to 3, maybe that would be a
> good compromise (though I'm in favor of getting rid of it completely).
> 
> -- 
> Sam.
> 

I like this proposal.
msg_Info, msg_Warn, msg_Err already give us 3 levels of "debug", and it 
will be a lot less confusing for end-users too.
Go for it, break everything ;-)

Just a clarification: As I understand it the messages output with msg_Info 
and msg_Err will always be enabled (or maybe you will have to use the 
--verbose or -v option to select msg_Info) and the messages output with 
msg_Warn will be selected as you described above (--warning aout). Is that 
what you propose ?

--
Gildas

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://www.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>



More information about the vlc-devel mailing list