[vlc-devel] BeOS interface CVS Commit

[Stephan Assmus]

Hello all,

sorry for commiting without useful message! Here is what my changes 
were:

modules/gui/beos/Interface.cpp

  - changed heap allocation of a BScreen object to a stack allocation
    reason: no good reason, just a habbit, and I fixed many leaks in
      the past when the allocated object was not deleted


modules/gui/beos/InterfaceWindow.h/.cpp

  - fixed a couple of memory leaks
    -> please consult BeBook if parameters passed to functions remain
    the callers responsibility to delete!
  - fixed a bunch of bugs
  - removed usage of second file panel by sharing one file panel for
    multiple tasks
    reason: user would have to navigate into a certain folder twice,
        to select a divx movie and the corresponding subtile file
        plus it's a waste of resources
  - changed a couple strings in the interface (eg "Show"->"Window"),
    if similar strings are freaquently used in other programs
  - reverted saving of UI settings to BeOS way
    reason: I had problems with the vlc way of saving them, plus the
        BeOS way gives some advantages, like forward compatibility and
        better error checking possibilities/default values
        however, I did not remove the other code, maybe I make both
        ways work right and selectable.
  - more UI settings are saved
  - code clean up, and migration of some useful code from 0.4.6


modules/gui/beos/ListViews.h/.cpp

  - more efficient/robust drag'n'drop indication code
  - modification of vlc playlist via drag'n'drop
  - improved class design in some parts
  - moved code arround from PlaylistWindow.cpp


modules/gui/beos/MediaControlView.cpp

  - fixed some locking bugs (crashes):
    wrong:
      LockLooper();
      ...
      UnlockLooper();
    right:
      if (LockLooper())
      {
        ...
        UnlockLooper();
      }
    these Be routines have return codes for a reason!


modules/gui/beos/MessagesWindow.cpp

  - see above


modules/gui/beos/PlayListWindow.h/.cpp

  - implemented some of the previously disabled menu items in edit menu
    - Select All/None
    - Remove (All)


modules/gui/beos/VideoWindow.h/VideoOutput.cpp

  - reimplemented saving of video settings with 0.4.6 code
    -> why got it removed without replacement?!?
    -> if it has to be the vlcrc file, just implement the saving
      in that way, don't remove useful code!


modules/gui/beos/VlcWrapper.h/.cpp

  - spotted some bugs

  - added methods for modifying the playlist
    (only PlaylistView class uses them)

  - changed OpenFiles() method to allow for insertion of items
    at any position (as used when files are dropped into playlist)





-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>