[vlc-devel] osdtext (0.6.0) fix + proposed patch

Olivier Aubert oaubert at bat710.univ-lyon1.fr
Thu Jun 26 16:44:16 CEST 2003


In the 0.6.0 version, the osdtext module does not run correctly, because
of a missing -lm library. It should be added to the configure.ac  file,
line 2126 (LDFLAGS_osdtext definition).

I am using osdtext from a CORBA remote control module, to display
information on the video screen (we are planning to implement a SVG
display module on the same base, if anyone is interested), and I need to
get a reference to the osdtext module. I propose the following patch,
which registers a new variable (osdtext-id) at the libvlc level. I would
be very glad to see it added to the current VLC tree, so that I do not
need to update it myself on every release.


--- vlc-0.6.0/modules/video_filter/osd_text.c	2003-06-11 22:36:22.000000000 +0200
+++ vlc-0.6.0-corba/modules/video_filter/osd_text.c	2003-06-26 15:05:55.000000000 +0200
@@ -220,6 +220,8 @@
     var_Create( p_vout, "string", VLC_VAR_STRING | VLC_VAR_ISCOMMAND );
     var_AddCallback( p_vout, "string", AddText, NULL );
+    /* Register the osdtext module at the root level */
+    var_Create (p_this->p_libvlc, "osdtext-id", VLC_VAR_INTEGER);
     val.psz_string = "Videolan";
 //    var_Set( p_vout, "string", val );
 //    p_vout->p_sys->p_strings->i_end_date = 0xFFFFFFFFFFFFFFF;
@@ -234,6 +236,7 @@
     int i_index;
     picture_t *p_pic;
+    vlc_value_t val;
@@ -259,6 +262,10 @@
+    /* Register the osdtext-id at the libvlc level */
+    val.i_int = p_vout->i_object_id;
+    var_Set (p_vout->p_libvlc, "osdtext-id", val);
     return VLC_SUCCESS;

This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>

More information about the vlc-devel mailing list