[vlc-devel] Re: configurable hotkeys

[Boris Dorès]

On Tue, May 27, 2003 at 08:28:47PM (GMT+0200), Gildas Bazin wrote:
> The only suggestion I might have would be not to do the hotkeys processing 
> in yet another interface module. IMHO this feature ought to be done in the 
> core.
> The way I would see it would be to split the event processing in 2 different 
> steps. The key events can be bound to a specific video output (for instance 
> the fullscreen one) so it would make sense to do a first processing of the 
> hotkeys in the vout thread (in src/video_output/video_output.c or a new 
> file).
> If we assume that hotkeys can be generated by something else than the video 
> outputs, then we need another point of centralisation for these hotkeys. 
> The playlist could be this other point. The events which are not handled by 
> the vout would then be redirected to the playlist events loop.

  I am not too sure about that. I can't see why the _playlist_
should process keys. In my opinion, playlists should remain a set of
core functions, totally platform independant, and only be called by
interfaces (the real bosses :) to manage ... playlists. They shouldn't
become a placeholder for miscellaneous functions.

  I think that key processing is definitely an interface task,
especially since each platform has its own standards as DJ already
noticed. I guess we should in fact simply provide a way for the user
to override platform's default hotkeys, and that this overriding system
could be platform independant and specified in the preferences (maybe we
could even provide a way to specifie a whole set of keys, for instance
to emulate another player).

  Nevertheless, there could be a module or a set of core functions
(personnally I don't really care but I know that Sam does, and he may
be right ;-) to help interfaces, but I don't know how we could do
this. Maybe a simple "which-key-is-bound-to-this-task" function would
suffice...

  As for the video output problem, which is the only other source of key
events for the time being, it should be solved by the integration of vout
windows in the interfaces. I know, it has been weeks that I told I would
code it : it will be done by the end of the week, I promise :)

  Does it seem roughly ok to you ?

-- 
babal
-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>