[vlc-devel] Re: vlc: svn commit r7364 (bigben)

[Sigmund Augdal]

Nice to see you work on this code. I have some simple suggestions/ideas
about this.

The first token of the o= field is the username of the person responsible
for the stream. It is supposed to be "-" if the username is not know or if
the announcement of it is not wanted.

the next two fields are supposed to make this session globally unique,
something they obviously isn't right now. They are recommended to be NTP
timestamp.

The u= field should contain a valid url. This field is optional, so we
should drop it for people that don't have a url specified.

The number after the / in the c= field is supposed to be the ttl of the
announce. This could be set to a sensible value and not be hardcoded to 15.

The type attribute should be "broadcast". And setting the suggested "tool"
attribute would be cool.

If you have more changes planed here, could you incorporate these? Otherwise
I could do it.


Sigmund

On Sat, Apr 17, 2004 at 11:22:41AM +0200, Subversion daemon wrote:
> r7364 | bigben | 2004-04-17 11:22:41 +0200 (Sat, 17 Apr 2004) | 10 lines
> Changed paths:
>    M /trunk/modules/stream_out/announce.c
>    M /trunk/modules/stream_out/announce.h
>    M /trunk/modules/stream_out/standard.c
> 
> * Little cleanup of sap announces :
> 
> - use net_* functions
> - use vlc_UrlParse function
> 
> change sap_session_t structure  : it now includes the  sdp packet, which
> isn't regenerated each time it is sent.
> 
> 
> 
> -- 
> This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
> To unsubscribe, please read http://developers.videolan.org/lists.html
> If you are in trouble, please contact <postmaster at videolan.org>

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>