[vlc-devel] vlc: svn commit r7492 (hartman)

R. Bernstein rocky at panix.com
Mon Apr 26 06:27:41 CEST 2004


Subversion daemon writes:
 >    M /trunk/modules/codec/ogt/cvd.c
 > 
 > * when you use object_find you need to do a object_release as well

Thanks for fixing. 

But I'm a bit confused. This "if":

  if( var_Get( p_input, "spu-channel", &val ) ) return NULL;

became unconditional: 

  var_Get( p_input, "spu-channel", &val );
  vlc_object_release( p_input );

which is a little bit different, no? If somehow the spu-channel
variable hasn't been set (or var_Get somehow fails), the intent is to
have this routine exit.

I see also ogt.c needs the same treatment and I'd have fixed, except
it is probably better to get this cleared up first.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>



More information about the vlc-devel mailing list