[vlc-devel] Re: CVS Commit (rocky)

[Jean-Paul Saman]

R. Bernstein wrote:
> Sigmund Augdal writes:
>  > Does this mean that it actually work without iconv? I whould be impressed.
> 
> No, it means that will compile which is better than what was there. If
> freetype doesn't work without iconv then those #ifdef's should be
> more pervasive and guarding just little bits of code. Or put in maybe
> something like:
> 
> #ifndef ICONV
>  error "you need libiconv to for freetype support"
> #endif
> 

This is a BAD IDEA!

If iconv is needed for freetype to work, then the above error should be 
generated in the ./configure state. In otherwords an appropriate check 
should be made in the configure.ac file. This is were autoconf is for!

Nothing is more irritating then finding out during the compile that you 
missed a library. That is why VLC comes with autoconf.

-- 
Kind greetings,

Jean-Paul Saman


-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>