[vlc-devel] Re: Transcoding on Solaris works

[Christophe Massiot]

On Fri, Apr 07, 2006, Kuldipsingh Pabla wrote:
> Hi Chris,
> 
> It is not that the NULL is being passed explicitly. It is when a 
> variable passed have  NULL value. For example in libmp4.c, 
> p_box->data.p_url->psz_location at line 701, was turning out to be NULL.

This is not valid in standard C and should indeed be fixed. So if you
can provide us with a patch, we'd greatly appreciate it.

> Christophe Massiot wrote:
> >On Fri, Apr 07, 2006, Kuldipsingh Pabla wrote:
> >
> >>Hi VLC Gurus,
> >>
> >>Replay of the transcoded file works for me now. While debugging the 
> >>issue, I found that *printf calls (like vprintf, sprintf,....) are the 
> >>main cause of segmentation faults on Solaris (not sure about other Unix 
> >>flavors). If the calling function passes a NULL value to *printf 
> >>functions, the *printf do not check for NULL and replace them with "". 
> >>As a result, they run into SEGFAULT. This is applicable to all the calls 
> >>to *print calls on Solaris. So my question is how should this be fixed 
> >>in the trunk? Should I provide you patches for all the *printf calls? Or 
> >>any other way??
> >
> >
> >We mustn't have any NULL arguments passed to the msg_* function, so if
> >there are cases, they must definitely be fixed.
> 
> -- 
> Project Buz :: Orchestrated Communication :: http://software.sfbay/buz
> 
> -- 
> This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
> To unsubscribe, please read http://developers.videolan.org/lists.html
-- 
Christophe Massiot.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html