[vlc-devel] Re: vlc: svn commit r14147 (sigmunau)

[Sigmund Augdal Helberg]

On Fri, 2006-02-03 at 15:45 +0100, Clément Stenac wrote:
> > seems they don't do it properly at least. Valgrind is unhappy with it.
> appart from the missing = 0 for i_total, I don't see where. Could you
> paste the errors ?
Here is one of the remaining ones:
==4429== Thread 3:
==4429== Use of uninitialised value of size 4
==4429==    at 0x8088E69: __stats_ComputeGlobalStats(vlc_messages.h:277)
==4429==    by 0x8057DA7: RunThread (playlist.c:605)
==4429==    by 0x1B97516A: pthread_start_thread
(in /lib/libpthread-0.10.so)
==4429==    by 0x1BAA3BA9: clone (in /lib/libc-2.3.4.so)

They don't seem to be critical, but they were hiding other errors by
flooding the logs etc.
> 
> For the performance issue, what is to be done is to extract the hash table
> handling from src/misc/variables.c and make it a global utility that can
> be reused by all our string-indexed tables, there are quite a few of them
> now :
>  - configuration
>  - stats
>  - metadata
>  - maybe others
> 
> Another easy optimization is to reduce the object_find calls in stats
> handling by keeping the singleton in libvlc_t
> 
> The next easy one is to change stats_UpdateFoo() so that it returns the
> new value of the counter after updating it, avoiding the lookup just after
> it.
This sounds promising, but much work. When this gets done I guess stats
would be very useful.

Sigmund
> 
> -- 
> Clément
> 

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html