[vlc-devel] [PATCH] Allow building against firefox 1.5 or seamonkey

Diego 'Flameeyes' Pettenò flameeyes at gentoo.org
Thu Jul 6 11:03:42 CEST 2006

So, I've already proposed this patch to xtophe on IRC a couple of days ago, 
but I left saying that I would have looked for a way to improve it to make it 
cleaner. Unfortunately I can't seem to find one, as I need anyway to either 
overload --enable-mozilla meaning or add another --with option, and between 
the two, the first seems more readable to me. So basically here it is the 

What this patch does is to make --enable-mozilla a parameter-based option, 
when it's used without parameter, it behaves exactly as before, but when used 
with a parameter, that is considered to be the name of the implementation to 
build against. When building against an implementation, it simply takes that 
as the prefix for -plugin and -xpcom pkgconfig datafiles, and thus use that 
to find the include paths and the library paths.
This allows to expand it to xulrunner using pkg-config if needed (although I 
only tested with Seamonkey and Firefox 1.5).

I'm not sure how else it can be done, the --with-mozilla-sdk-path does not 
work, and stuff linked against xulrunner is unlikely to work as intended on 
Seamonkey / Firefox, for what I'm told. This is the only way I could get VLC 
to build the plugin in Gentoo.

Diego "Flameeyes" Pettenò - http://farragut.flameeyes.is-a-geek.org/
Gentoo/Alt lead, Gentoo/FreeBSD, Video, AMD64, Sound, PAM, KDE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc-svn-firefox.patch
Type: text/x-diff
Size: 1777 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20060706/ba82d9c2/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20060706/ba82d9c2/attachment.sig>

More information about the vlc-devel mailing list