[vlc-devel] Re: [PATCH] Allow building against firefox 1.5 or seamonkey

Jean-Paul Saman jean-paul.saman at planet.nl
Sun Jul 9 17:49:36 CEST 2006


Diego 'Flameeyes' Pettenò wrote:
> So, I've already proposed this patch to xtophe on IRC a couple of days ago, 
> but I left saying that I would have looked for a way to improve it to make it 
> cleaner. Unfortunately I can't seem to find one, as I need anyway to either 
> overload --enable-mozilla meaning or add another --with option, and between 
> the two, the first seems more readable to me. So basically here it is the 
> patch.
> 
> What this patch does is to make --enable-mozilla a parameter-based option, 
> when it's used without parameter, it behaves exactly as before, but when used 
> with a parameter, that is considered to be the name of the implementation to 
> build against. When building against an implementation, it simply takes that 
> as the prefix for -plugin and -xpcom pkgconfig datafiles, and thus use that 
> to find the include paths and the library paths.
> This allows to expand it to xulrunner using pkg-config if needed (although I 
> only tested with Seamonkey and Firefox 1.5).
> 
> I'm not sure how else it can be done, the --with-mozilla-sdk-path does not 
> work, and stuff linked against xulrunner is unlikely to work as intended on 
> Seamonkey / Firefox, for what I'm told. This is the only way I could get VLC 
> to build the plugin in Gentoo.

Did you read the HOWTO on the developers page? You need to do something 
along these lines: XPIDL=/usr/lib/firefox-1.5.0 ./configure ... && make
for building against any given firefox installation on your system.

I am against this patch because it complicates an already complicated 
firefox/mozilla compilation. Just adding another option is IMHO 
overkill. If you could come up with an overall simpler solution for 
building the plugin for Windows, MacOS X, Linux (gentoo, debian, fedora, 
SuSE, etc.), then I would be interested.

Gtz,
Jean-Paul Saman.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html



More information about the vlc-devel mailing list