[vlc-devel] Re: vlc: svn commit r17999 (courmisch)

[Marian Durkovic]

On Thu, Nov 23, 2006 at 03:21:43PM +0100, R?mi Denis-Courmont wrote:
> Le jeudi 23 novembre 2006 14:50, Marian Durkovic a ?crit :
> > On Thu, Nov 23, 2006 at 02:36:50PM +0100, Subversion daemon wrote:
> > > r17999 | courmisch | 2006-11-23 14:36:49 +0100 (Thu, 23 Nov 2006) |
> > > 4 lines Changed paths:
> > >    M /branches/0.8.6/modules/misc/network/ipv4.c
> > >    M /branches/0.8.6/modules/misc/network/ipv6.c
> > >
> > > - Only try to use SSM when the group address is SSM itself
> > >   (afterall, we could specify a source/server even with ASM)
> >
> > This commit is broken. It prevents user from filtering out unwanted
> > ASM sources if someone is e.g. DOSing him.
> 
> VLC has never been able to properly filter out ASM sources (and not even 
> SSM sources in fact, though this is far more theoretical a problem), 
> since VLC never ever used connect() toward the right source address 
> when doing multicast. I DO intend to do that in 0.9.0.

This is not true. Under WinXP, if you issue SSM join, the OS properly
allows only the specified source. You have just broken this.


> If the commit is reverted, VLC will return to the very bad state where 
> it fails as soon as a source address is specified for ASM (why you've 
> been complaining about with SAP source-filter for so long).

No, with fallback which is already in IPv4 code it complains, but
correctly falls back to IGMPv2.


	M.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html