[vlc-devel] Re: vlc: svn commit r17986 (md)
ipkiss at via.ecp.fr
Fri Nov 24 00:31:46 CET 2006
On Thu, Nov 23, 2006, Rémi Denis-Courmont wrote:
> > This comment is stupid.
> Insults eh?
Please calm down, nobody insulted you. Saying that your comment is
stupid is not an insult. Everyone says or does something stupid once in
a while, even the most intelligent persons.
> So proposing a working and fast solution (fixing/upgrading the
> compiler) is stupid, and forward porting a *non-working* patch without
> even testing it is intelligent.
I find it rather funny that you criticize a non-tested patch, when you
broke the _compilation_ at least twice in the last 3 days. And I'm not
even talking about testing...
Now don't get me wrong, I think you are doing a very good job on VLC.
But once again, everyone can make mistakes. Yes, even you. You may not
realize it, but you are very arrogant on the mailing-list (and sometimes
on IRC as well), and this can really hurt people.
For example, you can very well disagree with a commit, or simply want to
'challenge' it. But instead of reverting it immediately, you could
consider asking for the reason of the commit first...
Or, to take the example of another recent thread, it's not because the
Windows network stack implementation is completely buggy that we can
accept regressions compared with previous versions. VLC is portable, and
saying "it works for me" is not enough. It must work still on as many
platforms as possible, and one must be careful not to break stuff for
the others as well. I can understand that you broke the Windows
behaviour since you work on Linux, or that md broke the Linux one since
he works on Windows. But now that you have identified the issues, why
not cooperating to find a solution working for both systems? This may
imply to find a dirty workaround for Windows, but nobody said that being
a developer is always fun and easy... :)
As a side note, maybe we could decide that a commit only comes after
full compilation + testing (if possible/relevant). I had the feeling
that it was an implicit rule for a long time, but it may be useful to
make it explicit, as a reminder.
> Stop commenting on stuff you know nothing about (like FreeBSD 4 gcc
> versions). You are being ridiculous (and insulting).
Oops, you can ignore all my previous comments, since I know nothing
about FreeBSD either :)
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
More information about the vlc-devel