[vlc-devel] Re: [PATCH] HW Pixel Doubling and Backlight-on for Maemo devices

[Hiltunen Tapio]

Hello,

You are right, the global variables shouldn't be there.
In this corrected patch, they are moved into the p_sys structure.

Tapio Hiltunen





-----Original Message-----
From: vlc-devel-bounce at videolan.org on behalf of Antoine Cellerier
Sent: Wed 4/18/2007 12:35 PM
To: vlc-devel at videolan.org
Subject: [vlc-devel] Re: [PATCH] HW Pixel Doubling and Backlight-on for Maemo devices
 
Hello,

On Wed, Apr 18, 2007, Hiltunen Tapio wrote:
> There has been several ports of VLC to Maemo devices. This patch adds some
> functionality to the x11 video output driver that the Maemo porters may
> find useful.
> These are:
> - Hardware pixel doubling: reduces CPU load in case that video
>   dimensions are less than half of the display dimensions (800x480 in N770
> and N800). Pixel
>   doubling is used only in fullscreen mode.
> - Keeping backlight on during playback.
> It also modifies configure.ac to provide switch --enable-maemo for
> inclusion of the above capabilities.

Why are you declaring global variables? (insted of putting them in the
vout's p_sys?) If you ever have 2 vouts runing at the same time it could
be problematic.

Other than that, the patch looks ok. Could someone with good knowledge
of the X video outputs comment?

Regards,

-- 
Antoine Cellerier
dionoea

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html




-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 11812 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070418/e928cbd3/attachment.bin>