[vlc-devel] Re: [PATCH] HW Pixel Doubling and Backlight-on for Maemo devices

[Christophe Mutricy]

>    - Hardware pixel doubling: reduces CPU load in case that video
>      dimensions are less than half of the display dimensions (800x480 in N770
>    and N800). Pixel
>      doubling is used only in fullscreen mode.
Could it be useful for other devices ? If yes, i think we should test
for the XSP stuff when we detect cflags and LDflags for the X11 modules
and teake it out of --enable-maemo


> +    VLC_ADD_CPPFLAGS([x11],[-DMAEMO -DHAVE_XSP -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/include/glib-2.0/glib  -I/usr/lib/glib-2.0/include])           
That doesn't look very cross-compilation friendly. I would expect the
majority of the apps for the nokia770 to be crosscompiled and the maemo
dev kit to be installed in a separate place than the system headers

> +const int MAEMO_BACKLIGHT_ON_INTERVAL = 300;
not sure what's better between that and 
#define MAEMO_BACKLIGHT_ON_INTERVAL 300

> +    p_maemo->i_backlight_on_counter = MAEMO_BACKLIGHT_ON_INTERVAL; 
> +    p_maemo->p_octx = osso_initialize( "vlc", "0.8.6a", 0, NULL );
It should use VLC_VERSION or whatever the #define is. So we don't have
to change it at each release.

-- 
Xtophe

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html