[vlc-devel] Re: [PATCH] HW Pixel Doubling and Backlight-on for Maemo devices

[Remi Denis-Courmont]

On Wed, 18 Apr 2007 15:15:09 +0200, Christophe Mutricy 
<xtophe at nxtelevision.com> wrote:
>> +    VLC_ADD_CPPFLAGS([x11],
[-DMAEMO -DHAVE_XSP -I/usr/include/dbus-1.0
> -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0
> -I/usr/include/glib-2.0/glib  -I/usr/lib/glib-2.0/include])
> That doesn't look very cross-compilation friendly. I would expect the
> majority of the apps for the nokia770 to be crosscompiled and the
> maemo dev kit to be installed in a separate place than the system
> headers 

FYI... with the poor state of cross-compilation support for Debian 
packages, it would be pretty much impossible to officially use 
cross-compilation for Nokia tablets. In practice, scratchbox provides a 
native-looking build environment.

I agree however that an automated test (e.g. for libosso) would be 
better than a hard-wired --enable-maemo.

>> +const int MAEMO_BACKLIGHT_ON_INTERVAL = 300;
> not sure what's better between that and
> #define MAEMO_BACKLIGHT_ON_INTERVAL 300

IMHO, that's irrelevant. The compiler can optimize it this.

I am not a big fan of using ALL_CAPS_NAMES for stuff that is not a 
macro, though.

>> +    p_maemo->i_backlight_on_counter = MAEMO_BACKLIGHT_ON_INTERVAL;
>> +    p_maemo->p_octx = osso_initialize( "vlc", "0.8.6a", 0, NULL );
> It should use VLC_VERSION or whatever the #define is. So we don't have
> to change it at each release.

AFAIK, VERSION or PACKAGE_VERSION from config.h.

--
Rémi Denis-Courmont
http://www.remlab.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070418/296f8c7b/attachment.sig>