[vlc-devel] Re: [PATCH] Quartz subtitle renderer] - RESEND

[Pierre d'Herbemont]

On 23 avr. 07, at 20:04, Jean-Baptiste Kempf wrote:

> On Mon, Apr 23, 2007, Bernie Purcell wrote :
>> Nothing seems to have happened with this patch since I last submitted
>> it. Does anyone have anything to say?
>
> feepk? pdherbemont ?

Sorry, I thought thedj was on it. Seems fine, also, I didn't tested.  
I could do that tomorrow or wednesday.

Just a small note:

> +#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_4
> +        *pp_colorSpace = CGColorSpaceCreateWithName 
> ( kCGColorSpaceGenericRGB );
> +#else
> +        *pp_colorSpace = CreateGenericRGBColorSpace();
> +#endif

You could use here weak linking to see if the functions are present.  
Anyway Mac OS X < 10.4 support is now dropped from trunk.

Thanks Bernie!

Pierre.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070423/64f0b006/attachment.html>