[vlc-devel] Re: [PATCH] Quartz subtitle renderer] - RESEND

[Bernie Purcell]

On Mon, 2007-04-23 at 20:15 +0200, Pierre d'Herbemont wrote:
> 
> 
> Just a small note:
> 
> 
> 
> > +#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_4
> > +        *pp_colorSpace =
> > CGColorSpaceCreateWithName( kCGColorSpaceGenericRGB );
> > +#else
> > +        *pp_colorSpace = CreateGenericRGBColorSpace();
> > +#endif
> 
> 
> You could use here weak linking to see if the functions are present.
> Anyway Mac OS X < 10.4 support is now dropped from trunk.
> 
> 
> Thanks Bernie!
> 
> 
> Pierre.

In my defence 10.3 was still supported when I submitted the patch ;-).
I don't have a problem using weak linking but coded it this way because
I couldn't find any reference to the minimum supported OS X version on
the site (not saying it isn't there - I just couldn't find it) so
thought I'd play it safe. 10.1 (or is it 10.0?) didn't support weak
linking so I used ifdef's instead.

:-)

Bernie

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html