[vlc-devel] [Patch] Jack input fixes

Christophe Mutricy xtophe at nxtelevision.com
Thu Aug 30 23:42:26 CEST 2007


On Thu, Aug 30, 07 at 09:14 -0400, Pierre-Luc Beaudoin wrote:
>    As per Christophe Mutricy request,  I splitted my patch.
>    This part covers Jack Input bugfixes and some more options:
>    - bug: cracking in the captured sound
>    - autoconnect to inputs
>    - use VLC pace

Even after adding unistd.h, it doesn't compiles cleanly here:

../../../modules/access/jack.c: In function 'Process':
WARNING : ../../../modules/access/jack.c: 428:  passing argument 2 of
'jack_ringbuffer_write' from incompatible pointer type
../../../modules/access/jack.c: In function 'GrabJack':
WARNING : ../../../modules/access/jack.c: 473:  pointer targets in
passing argument 2 of 'jack_ringbuffer_read' differ in signedness
../../../modules/access/jack.c: In function 'Port_finder':
WARNING : ../../../modules/access/jack.c: 527:  assignment discards
qualifiers from pointer target type

Not sure if they are all caused by your patch, but it should be fixed
before commit.



More information about the vlc-devel mailing list