[vlc-devel] [Patch] Jack input fixes

[Pierre-Luc Beaudoin]

Hi,

I removed all the warnings for jack.c .

Also by Rémi Denis-Courmont comments, I changed the way I find the power
of 2 not to use <math.h>.  

Le jeudi 30 août 2007 à 23:42 +0200, Christophe Mutricy a écrit :

> Hello,
> 
> On Thu, Aug 30, 07 at 09:14 -0400, Pierre-Luc Beaudoin wrote:
> >    As per Christophe Mutricy request,  I splitted my patch.
> > 
> >    This part covers Jack Input bugfixes and some more options:
> >    - bug: cracking in the captured sound
> >    - autoconnect to inputs
> >    - use VLC pace
> 
> Even after adding unistd.h, it doesn't compiles cleanly here:
> 
> ../../../modules/access/jack.c: In function 'Process':
> WARNING : ../../../modules/access/jack.c: 428:  passing argument 2 of
> 'jack_ringbuffer_write' from incompatible pointer type
> ../../../modules/access/jack.c: In function 'GrabJack':
> WARNING : ../../../modules/access/jack.c: 473:  pointer targets in
> passing argument 2 of 'jack_ringbuffer_read' differ in signedness
> ../../../modules/access/jack.c: In function 'Port_finder':
> WARNING : ../../../modules/access/jack.c: 527:  assignment discards
> qualifiers from pointer target type
> 
> Not sure if they are all caused by your patch, but it should be fixed
> before commit.
> 
> Regards,
> 

--
Pierre-Luc Beaudoin
Savoir-faire Linux


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070831/8501b389/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jack-fixes.patch
Type: text/x-patch
Size: 11539 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070831/8501b389/attachment.bin>