[vlc-devel] vlc: svn commit r23497 (dionoea)

Rémi Denis-Courmont rdenis at simphalempin.com
Sun Dec 9 11:46:53 CET 2007


Le Saturday 08 December 2007 18:53:58 Subversion daemon, vous avez écrit :
> r23497 | dionoea | 2007-12-08 17:53:56 +0100 (Sat, 08 Dec 2007) | 2 lines
> Changed paths:
>    M /trunk/include/vlc_variables.h
>    M /trunk/src/misc/variables.c
>
> Add VLC_VAR_GET{MIN,MAX,STEP} commands.

I wonder if we really need yet another set of bit flags here. Perhaps storing 
correct default values (min=0 or INT_MIN, max=INT_MAX and step=1) would allow 
detecting the "no" case.

> Make it possible to use VLC_VAR_INHERITVALUE with a 2nd argument which
> will be used as the variable name to inherit (for example you want to
> inherit a variable named "v4l2-hue" into a variable named "hue":

I suspect I don't understand what this does too well. But it looks like a big 
hack. Some plugins have this (e.g. for custom TTL), they simply get the 
variable, and create/set the new one to the same value.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list