[vlc-devel] vlc: svn commit r23497 (dionoea)

[Antoine Cellerier]

On Sun, Dec 09, 2007, Rémi Denis-Courmont wrote:
> Le Saturday 08 December 2007 18:53:58 Subversion daemon, vous avez écrit :
> > r23497 | dionoea | 2007-12-08 17:53:56 +0100 (Sat, 08 Dec 2007) | 2 lines
> > Add VLC_VAR_GET{MIN,MAX,STEP} commands.
> 
> I wonder if we really need yet another set of bit flags here. Perhaps storing 
> correct default values (min=0 or INT_MIN, max=INT_MAX and step=1) would allow 
> detecting the "no" case.

Maybe ... I only added the getters, not the min/max/step functionality
itslef.

> > Make it possible to use VLC_VAR_INHERITVALUE with a 2nd argument which
> > will be used as the variable name to inherit (for example you want to
> > inherit a variable named "v4l2-hue" into a variable named "hue":
> 
> I suspect I don't understand what this does too well. But it looks like a big 
> hack. Some plugins have this (e.g. for custom TTL), they simply get the 
> variable, and create/set the new one to the same value.

Basically the reason for this change is:
Modules usually do stuff like var_CreateGetInteger(p_this, "module-var");
If you want to change the variable in the rc or telnet interface you
then need to use:
@module module-var value
With this change, you could instead change the variable name in the
module itself to remove the "module-" prefix. Hence the command in the
rc interface would be:
@module var value

(This new option to the INHERIT VALUE command isn't used anywhere yet)

-- 
Antoine Cellerier
dionoea