[vlc-devel] vlc: svn commit r23595 (jpsaman)

[Rafaël Carré]

Le Thu, 13 Dec 2007 22:11:37 +0100,
Jean-Paul Saman <jean-paul.saman at planet.nl> a écrit :

> Rafaël Carré wrote:
> > Le Thu, 13 Dec 2007 17:39:33 +0100 (CET),
> > Subversion daemon <svn at videolan.org> a écrit :
> > 
> >> r23595 | jpsaman | 2007-12-13 17:39:33 +0100 (Thu, 13 Dec 2007) | 2
> >> lines Changed paths:
> >>    M /trunk/src/playlist/control.c
> >>
> >> Patch by Jilles Tjoelker. Fixes crash in playlist due to negative
> >> index in playlist item array. Added boundary check to solve this.
> > 
> > It would be good to know where this negative index comes from,
> > rather than hiding the problem.
> > 
> > Can you have more details, like, when this crash happens (at init,
> > while doing some specific thing ?, at exit ?) and if possible a
> > backtrace ?
> > 
> > This variable is used through array functions (vlc_array.h) so at
> > first sight i suspect a race condition either when changing the
> > "current" playlist, or at initialisation.
> 
> If you startup with an m3u playlist item and press backwards, then
> vlc immediately segfaults, because the Index = -2.

I suppose you are using ncurses interface.

If this is the case, please revert the commit if [23600] fixes your bug.

> I'll try to produce a stacktrace later.
> 
> Gtz,
> Jean-Paul Saman.
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel


-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20071213/f745031a/attachment.sig>