[vlc-devel] vlc: svn commit r23595 (jpsaman)

[Jean-Paul Saman]

Rafaël Carré wrote:
> Le Thu, 13 Dec 2007 22:11:37 +0100,
> Jean-Paul Saman <jean-paul.saman at planet.nl> a écrit :
> 
>> Rafaël Carré wrote:
>>> Le Thu, 13 Dec 2007 17:39:33 +0100 (CET),
>>> Subversion daemon <svn at videolan.org> a écrit :
>>>
>>>> r23595 | jpsaman | 2007-12-13 17:39:33 +0100 (Thu, 13 Dec 2007) | 2
>>>> lines Changed paths:
>>>>    M /trunk/src/playlist/control.c
>>>>
>>>> Patch by Jilles Tjoelker. Fixes crash in playlist due to negative
>>>> index in playlist item array. Added boundary check to solve this.
>>> It would be good to know where this negative index comes from,
>>> rather than hiding the problem.
>>>
>>> Can you have more details, like, when this crash happens (at init,
>>> while doing some specific thing ?, at exit ?) and if possible a
>>> backtrace ?
>>>
>>> This variable is used through array functions (vlc_array.h) so at
>>> first sight i suspect a race condition either when changing the
>>> "current" playlist, or at initialisation.
>> If you startup with an m3u playlist item and press backwards, then
>> vlc immediately segfaults, because the Index = -2.
> 
> I suppose you are using ncurses interface.
> 
> If this is the case, please revert the commit if [23600] fixes your bug.

No we are using lirc and press channel down. But I'll check out the 
revision.

Gtz,
Jean-Paul Saman