[vlc-devel] Re: vlc: svn commit r18807 (md)

Marian Durkovic md at bts.sk
Mon Feb 12 11:41:10 CET 2007


On Mon, Feb 12, 2007 at 09:57:50AM +0100, Remi Denis-Courmont wrote:
> 
> On Mon, 12 Feb 2007 08:12:11 +0100 (CET), Subversion daemon <svn at videolan.org> wrote:
> > r18807 | md | 2007-02-12 08:12:11 +0100 (Mon, 12 Feb 2007) | 3 lines
> > Changed paths:
> >    M /trunk/src/libvlc-common.c
> >    M /trunk/src/misc/win32_specific.c
> >    M /trunk/src/vlc.c
> > 
> > Move __wgetmainargs into VLC's main.
> 
> Good. One thing i was wondering, though: how come the latter FromLocale() invocation does not 
> conflict with __wgetmainargs?

This FromLocale is not being called for unicode Windows versions as before.

As I've noted in the comment, the FromLocale call should be moved
elsewhere also for other operating systems, since it's too late to
call it at GetFilenames(). We need conversion to UTF8 also for global
and mrl-specific options - see #838.

I'd suggest to convert all arguments to UTF8 in VLC's main for all OSs
and always call LibVLC with arguments already in UTF8.


	With kind regards,

		M.

--------------------------------------------------------------------------
----                                                                  ----
----   Marian Durkovic                       network  manager         ----
----                                                                  ----
----   Slovak Technical University           Tel: +421 2 524 51 301   ----
----   Computer Centre, Nam. Slobody 17      Fax: +421 2 524 94 351   ----
----   812 43 Bratislava, Slovak Republic    E-mail/sip: md at bts.sk    ----
----                                                                  ----
--------------------------------------------------------------------------

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html



More information about the vlc-devel mailing list