[vlc-devel] Re: [PATCH] italic tag support fo MPL2 subtitles

[Rémi Denis-Courmont]

Le mardi 20 février 2007 19:26, Roman Bednarek a écrit :
>   To complete MPL2 subtitles support I have added parsing italic tag
> "/" and rendering italic subtitle.
>   This patch is a little intrusive, it embeds control tags for text
> renderer into the text. It does not use text_style_t struct because
> there is no way (I could find) it can be different for different
> parts of a single subtitle.
>   If this patch gets accepted I plan to add suport for some MicroDVD
> formating tags in the same way.

Hmmph, this patch seems to be using valid printable character sequences 
as escape codes for italic. IMHO, this is not a good idea at all.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070220/d70019ec/attachment.sig>