[vlc-devel] Re: [PATCH] italic tag support fo MPL2 subtitles
roman at mikronika.com.pl
Tue Feb 20 19:54:12 CET 2007
On Tue, 20 Feb 2007, [windows-1252] Rémi Denis-Courmont wrote:
> Le mardi 20 février 2007 19:26, Roman Bednarek a écrit :
>> To complete MPL2 subtitles support I have added parsing italic tag
>> "/" and rendering italic subtitle.
>> This patch is a little intrusive, it embeds control tags for text
>> renderer into the text. It does not use text_style_t struct because
>> there is no way (I could find) it can be different for different
>> parts of a single subtitle.
>> If this patch gets accepted I plan to add suport for some MicroDVD
>> formating tags in the same way.
> Hmmph, this patch seems to be using valid printable character sequences
> as escape codes for italic. IMHO, this is not a good idea at all.
I considered using non printable ESC=27(ascii) as an escape code, but I
was not sure how other renderers will react to it (for now I adapted only
freetype renderer), if it is not a problem I too think non-printable
character would be better.
(I can change the patch if you think it will be better)
More information about the vlc-devel