[vlc-devel] Re: [PATCH] Matroska Attachments

Laurent Aimar fenrir at via.ecp.fr
Mon Jun 4 00:22:36 CEST 2007


On Fri, Jun 01, 2007, Bernie Purcell wrote:
> On Thu, 2007-05-31 at 21:28 +0200, Laurent Aimar wrote:
> 
> >  If you prefer I can add a decoder_GetAllInputAttachment that will return
> > them all but you can receive unneeded attachments and so waste a bit more 
> > memory...
> > 
> >  Report any problems (I have not tested it)
> Thankyou for the amount of effort you had to go to to clean up my mess.
> I seriously don't think I would have worked out how to have done this
> myself if I'd had a million years to work on it. I really appreciate it.
 You are welcome.

> I may have to take you up on your offer of this additional function
> though, if it's ok with you (either that or a way to retrieve an
> attachment by index). This would allow us to step through all the
> attachments available, filtering them according to what the module
> supports and processing them into appropriate structures, eg picture_t,
> p_face etc. just the once during decoder open stage (before we know what
> the attachment names might be), rather than on-demand each time they are
> referenced by name. Would this be ok?
 Done, I have added decoder_GetInputAttachments that will return all input attachments
at once (You have to free them once you are done with them).

Regards,

-- 
fenrir

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html



More information about the vlc-devel mailing list