[vlc-devel] Re: vlc: svn commit r19083 (courmisch)

[Pierre d'Herbemont]

On 1 mars 07, at 18:52, Subversion daemon wrote:

> r19083 | courmisch | 2007-03-01 18:52:11 +0100 (Thu, 01 Mar 2007) |  
> 4 lines
> Changed paths:
>    M /trunk/include/vlc_threads.h
>    M /trunk/src/vlc.c
>
> Fix abortion if killing signals are re-used.
> Of course, VLC has no bugs, so you never to abort it that way,
> so that this fixes nothing.
>
>> http://trac.videolan.org/vlc/changeset/19083

> @@ -172,14 +173,14 @@
>      i_ret = VLC_AddIntf( 0, NULL, VLC_TRUE, VLC_TRUE );
> +    /* Finish the threads */
> +    VLC_CleanUp( 0 );
> +
> +    /* Destroy the libvlc structure */
> +    VLC_Destroy( 0 );
> +
> #if !defined(WIN32) && !defined(UNDER_CE)
>      pthread_cancel (sigth);
>      pthread_join (sigth, NULL);
> #endif
> -
> -    /* Finish the threads */
> -    VLC_CleanUp( 0 );
> -
> -    /* Destroy the libvlc structure */
> -    VLC_Destroy( 0 );

Seems wrong to me as VLC_Destroy() will destroy p_libvlc. And the  
thread sigth could trigger VLC_Die() which makes use of p_libvlc,  
resulting in a crash. So we have to cancel the thread before calling  
VLC_Destroy(). What was the reason for that change?

Pierre.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html