[vlc-devel] Re: vlc: svn commit r19270 (jpsaman)

[Jean-Paul Saman]

Rémi Denis-Courmont wrote:
> Le samedi 10 mars 2007 18:53, Jean-Paul Saman a écrit :
>> Rémi Denis-Courmont wrote:
>>> Le samedi 10 mars 2007 18:29, Subversion daemon a écrit :
>>>> r19270 | jpsaman | 2007-03-10 17:29:38 +0100 (Sat, 10 Mar 2007) |
>>>> 1 line Changed paths:
>>>>    M /trunk/modules/access_filter/dump.c
>>>>
>>>> Remove useless test
>>> WTF? Of course assertions are ALWAYS TRUE. That does not mean you
>>> have to remove them!
>> The issue here is that len is of type size_t which is unsigned and
>> thus always >= 0. It actually tests nothing.
> 
> Can you see the difference between: “assert (len > 0);” and “assert (len 
>> = 0);” ? At least, I can, and GCC can too (it prints a warning about 
> always true statement in the second case).
> 
> Regards,
> 
Remi, I can see the difference but clearly my earlier observation was 
wrong. Thanks for spotting it.

Gtz,
Jean-Paul Saman.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html