[vlc-devel] Re: vlc: svn commit r19270 (jpsaman)

[Jean-Paul Saman]

Jean-Paul Saman wrote:
> Rémi Denis-Courmont wrote:
>> Can you see the difference between: “assert (len > 0);” and “assert (len
>>> = 0);” ? At least, I can, and GCC can too (it prints a warning about 
>> always true statement in the second case).
>>
>> Regards,
>>
> Remi, I can see the difference but clearly my earlier observation was 
> wrong. Thanks for spotting it.
> 
Well I take those words back. Line 159 already checks for the case (len ==0)

line 159:
     if (len == 0)
         return; /* no useful data */

This makes the assert( len > 0 ) useless because it is guaranteed to be 
greater then zero.

gtz,
Jean-Paul Saman.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html