[vlc-devel] Re: [PATCH]automatic subtitle detection (windows)

[Antoine Cellerier]

Hello,

On Thu, May 03, 2007, Hannes Domani wrote:
> the automatic detection of subtitle-files is broken on
> the windows-svn-build.
> 
> problem: subtitles_Detect() expects a file in the
> format of "file://c:\path\to\file.avi", but gets on
> windows "file:///c:/path/to/file.avi".
> 
> it still worked at 0.8.6b, i think.
> i saw that the path-separator changed from
> 'DIRECTORY_SEPARATOR' to 'DIR_SEP_CHAR', this might be
> part of the problem. or did you change the way the
> paths are stored ("file://" -> "file:///")?
> 
> my solution was easy, ignore '/' at the beginning, and
> get the real last separator.
> 
> i know this might not be the 'nicest' solution, but
> its working.

Thanks for the patch.

It looks ok as a work arround but we should focus on the problem's
source instead. (that's fixing the file:///c:/ stuff so that it uses
file://c:/)

Anyone have a clue?

-- 
Antoine Cellerier
dionoea

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html