[vlc-devel] Re: Crash while seeking a Matroska file (Ticket #1006 et all) -fix

[Christophe Mutricy]

On Wed, May 09, 07 at 04:32 +0300, Harry Sintonen wrote:
> I've tracked down the MKV seek crash to modules/demux/mkv.cpp
> void matroska_segment_c::Seek( mtime_t i_date, mtime_t i_time_offset )
> 
> The 'while( i_track_skipping > 0 )' -loop does BlockGet() to get the 
> 'block'. However for LIBMATROSKA_VERSION >= 0x000800 it can happen that 
> the 'block' is NULL, resulting in NULL references later in the loop:
> 
>             if( tracks[i_track]->i_number == block->TrackNum() )
> 
> and:
> 
>         sys.i_pts = (sys.i_chapter_time + block->GlobalTimecode()) / 
>         (mtime_t) 1000;
> 
> I've included a proposed fix as an attachment (I bet those long lines
> would barf).

Applied. Thanks

-- 
Xtophe

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html