[vlc-devel] Re: [PATCH] USF subtitles enhancements

[Bernie Purcell]

On Wed, 2007-05-23 at 19:31 +0200, Jean-Baptiste Kempf wrote:
> On Wed, May 23, 2007, Bernie Purcell wrote :
> > This patch brings the USF subtitle support more in line with the spec by
> > adding support for additional features. It is still not complete, but
> > the patch was quite big enough already at this point. :-/
> Nice patch as usual,
> 
> > * Add a shortname to sdl_image so we can do a module_Exists() on it
> I don't really get that in fact, and I don't really see why you use it.
> That is because SDL_image display correctly images that ffmpeg doesn't ?
> 
> Still, SDL_image should have a better score than ffmpeg, so if there is 
> SDL_image, it will be used, and if it isn't, the fallback will be on 
> ffmpeg.
> Or did I totally misunderstood it ?
Nope, I'd be most happy with that type of a solution :-) - I did it this
way (and I'm aware it's a hack of a way to do it) because changing the
scores of modules could have affected a great many things in other parts
of vlc, and I wasn't prepared to judge.
I also thought about just removing the bit in ffmpeg module that says it
can handle BMP, as that is what is causing the problem (at least in my
tests with these particular BMPs). I thought, however, that there may
have been other types it had problems with, too, and that that wouldn't
have fixed it for them.
Is anyone in a position to make a call over whether giving sdl_image a
higher score than ffmpeg would cause problems to any other particular
module?
> 
> 
> -- 
> Jean-Baptiste Kempf
> http://www.jbkempf.com/
> 

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html