[vlc-devel] Re: [PATCH] USF subtitles enhancements

Jean-Baptiste Kempf jb at videolan.org
Thu May 24 08:35:17 CEST 2007


On Thu, May 24, 2007, Bernie Purcell wrote :
> I also thought about just removing the bit in ffmpeg module that says it
> can handle BMP, as that is what is causing the problem (at least in my
> tests with these particular BMPs). I thought, however, that there may
> have been other types it had problems with, too, and that that wouldn't
> have fixed it for them.
> Is anyone in a position to make a call over whether giving sdl_image a
> higher score than ffmpeg would cause problems to any other particular
> module?

If ffmpeg bmp is that poor, we can remove it from VLC's ffmpeg.c,

however, I would prefer putting the sdl_image's score higher than
ffmpeg, since the only FourCC supported in sdl_image are:
    { VLC_FOURCC('t','g','a',' '), "TGA" },
    { VLC_FOURCC('b','m','p',' '), "BMP" },
    { VLC_FOURCC('p','n','m',' '), "PNM" },
    { VLC_FOURCC('x','p','m',' '), "XPM" },
    { VLC_FOURCC('x','c','f',' '), "XCF" },
    { VLC_FOURCC('p','c','x',' '), "PCX" },
    { VLC_FOURCC('g','i','f',' '), "GIF" },
    { VLC_FOURCC('j','p','e','g'), "JPG" },
    { VLC_FOURCC('t','i','f','f'), "TIF" },
    { VLC_FOURCC('l','b','m',' '), "LBM" },

in which they are probably in a higher quality than ffmpeg. (though
ffmpeg should be faster).

Anyone knows if this is a good/bad idea ?


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html



More information about the vlc-devel mailing list