[vlc-devel] Real Video Decoding....

[Remi Denis-Courmont]

On Tue, 06 Nov 2007 10:07:20 +0100, Jean-Paul Saman
<jean-paul.saman at planet.nl> wrote:
> Other remarks:
> - don't use // comments in c code, but /* .. */

Urban legend. C standards do specify // comments.

> - coding style if( ) iso if () etc.

VLC idiosyncrasic coding style is pretty insane, if only by being so
much different from common use. Sure different projects have different
religious conception about coding styles, but VLC does not even follow
what every body else agrees on (no spaces inside parenthesis).

Sticking hard to these won't help attract very much needed development
skills.

> - cleanup of code flow, especially handling of p_sys
> - on fail of malloc it should return VLC_ENOMEM iso VLC_EGENEREIC
> - removal of dead code

Yes.

-- 
Rémi Denis-Courmont
http://www.remlab.net