[vlc-devel] Real Video Decoding....

[Jean-Baptiste Kempf]

On Tue, Nov 06, 2007, Jean-Paul Saman wrote :
> This patch is messed up bigtime. I counted 3 times it assigns 
> p_dec->pf_decode_video. It mallocs p_sys in an unusual place, which 
> propably makes the handling of p_dec->p_sys far from stable.
I'll see what I can do. Communication on the forum is not easy...

> Other remarks:
> - don't use // comments in c code, but /* .. */
> - coding style if( ) iso if () etc.
Cosmetic could be nice, but later.

> - cleanup of code flow, especially handling of p_sys
I'll see what I can do.

> - on fail of malloc it should return VLC_ENOMEM iso VLC_EGENEREIC
OK.

> - removal of dead code
Ok.

> For the rest it looks quite ok.
I am really unsure about the loader part of the code, like the 
#ifdef WIN32
...

#ifdef LOADER
...
#endif

#else
> BTW I don't have time to cleanup this patch, so I guess one of the win 
> devs should do this. Trax maybe?
The code should work on linux too.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/