[vlc-devel] multiple aout instances?

[Artem Baguinski]

On Nov 15, 2007 9:09 PM, Antoine Cellerier <dionoea at videolan.org> wrote:
> > Oh, then I'd have to clean the patch AND update it to svn HEAD. I work
> > with 0.8.6c so I can reuse debian packaging stuff - I want my
> > collegues to be able to just dpkg -i my custom vlc + plugin(s). But I
> > guess I could clone your git tree, find 0.8.6c, apply my patches there
> > and then merge to master...
> >
> > Yeah, I'll do that right now...
>
> Awesome :) (Please send a seperate patch for the audio core changes too)

since this patch is much simpler I'll start with it, please review

explanation: without the --multi-aout the behaviour is almost
identical to HEAD,
safe for the following hunk in src/audio_output/dec.c:

@@ -190,7 +195,7 @@ aout_input_t * __aout_DecNew( vlc_object_t * p_this,
             {
                 return NULL;
             }
-            vlc_object_attach( *pp_aout, p_this->p_libvlc );
+            vlc_object_attach( *pp_aout, p_this );
         }
         else
         {


which I don't expect to break anything, but correct me if I'm wrong.
this attaches the aout to decoder instead of the libvlc instance, that
is necessary for aout instances to be able to find their properties
set with "setup ... option ..." in vlm.

with --multi-aout option, when decoder has to create an aout it only
looks in it's parents for existing one and creates one if none found.
This way each vlm medium gets its own instance of aout module.

At the moment this really is only of interest to the openal plugin,
which knows how to deal with multiple instances of itself (only the
first created instance tries to open device, access to device is
synchronized with a mutex etc).

I'll submit the OpenAL plugin for your review whenever it's in better shape.

-- 
cheers,
artm

http://lab.v2.nl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multi-aout.patch
Type: text/x-patch
Size: 2382 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20071116/88707ef4/attachment.bin>