[vlc-devel] vlc: svn commit r22437 (funman)

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Dalgliesh a écrit :
> 
> Hi,
> 
> On Thu, 4 Oct 2007 at 20:23 +0200, Subversion daemon wrote:
>>
>> r22437 | funman | 2007-10-04 20:23:08 +0200 (Thu, 04 Oct 2007) | 1 line
>> Changed paths:
>>   M /trunk/extras/contrib/src/Makefile
>>
>> contribs: don't build faad shared library
>> > http://trac.videolan.org/vlc/changeset/22437
> 
> As far as I can tell, this change causes the Mac OS X (and probably
> BeOS) build to fail. It still tries to install a faad dynamic library -
> see the buildbot logs.

macosx buildbots both fail to build, but the intel one because of
ffmpeg, and the ppc one because of a misconfiguration of the buildbot,
I don't see any log about faad

> I've attached a patch which I believe should fix it. VLC then builds
> correctly and seems to run OK too. I tried playing an AAC file and it
> worked and said it used the 'faad' module.

In fact it is built correctly, but the macro INSTALL_NAME is here to
manage shared libraries, and there is nothing to manage, so we juste
remove it.

> That said I'm not 100% sure it's correct, please check it.

it's ok, i committed your patch.

Thanks

> 
> {P^/
> John

By the way I noticed there was a lot of places where shared libraries
are used. We should review it, and build only static libraries when
there is one and only one module using that lib.

I'll ask details to j-b, who maintains the contribs.

- --
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHCje8YWCeGMCv8Q8RAosvAJ0YqosF8k+qM9nxQEuvFdZoFnyj8ACfZXy3
hnGtafUku0cnbxMmxze84fI=
=ge0Y
-----END PGP SIGNATURE-----